Opened 2 years ago
Closed 2 years ago
#289 closed defect (fixed)
typos and grammar mistakes
| Reported by: | cavedon | Owned by: | laurent |
|---|---|---|---|
| Priority: | trivial | Milestone: | QuteCom 2.3 |
| Component: | GUI | Version: | 2.2 |
| Keywords: | Cc: |
Description
From http://bugs.debian.org/603260:
In QuteCom - Configuration General Settings "Prefere" is misspelled, should be "Prefer". "Prefere start a free call if applicable" is a grammatical error, could be "Start free phone call if possible". "Prefere start a chat" is a grammatical error, could be "Start a chat"
Plus some other spelling mistakes reported by lintian:
I: qutecom: spelling-error-in-binary ./usr/bin/qutecom informations information I: qutecom: spelling-error-in-binary ./usr/bin/qutecom unknonw unknown I: qutecom: spelling-error-in-binary ./usr/lib/qutecom/libphapi.so ressource resource I: qutecom: spelling-error-in-binary ./usr/lib/qutecom/libwebcam.so quering querying I: qutecom: spelling-error-in-binary ./usr/lib/qutecom/libwebcam.so Choosen Chosen
Attachments (1)
Change History (7)
comment:1 Changed 2 years ago by laurent
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed 2 years ago by cavedon
- Resolution fixed deleted
- Status changed from closed to reopened
Thanks laurent for the fix.
However the spelling errors reported by lintian are still present:
I: qutecom: spelling-error-in-binary ./usr/bin/qutecom informations information I: qutecom: spelling-error-in-binary ./usr/bin/qutecom unknonw unknown I: qutecom: spelling-error-in-binary ./usr/lib/qutecom/libphapi.so ressource resource I: qutecom: spelling-error-in-binary ./usr/lib/qutecom/libwebcam.so quering querying I: qutecom: spelling-error-in-binary ./usr/lib/qutecom/libwebcam.so Choosen Chosen
comment:3 follow-up: ↓ 5 Changed 2 years ago by dneary
Seems like this bug fix got lost along the way... the wrong grammar is present in the trunk now. Also, informations makes its way into an .ui file, LogAccount?.ui (and thus into the user interface & .ts files).
For most of the other spelling errors, they're in code comments mostly - in a few places there are some documentation issues we can fix. Also, a lot of these are in eXoSIP, which is an upstream for us. Fixes should really get proposed there.
Some of the "informations" and "ressources" are in French language comments or translations, and are thus correct.
Also, I don't think it's appropriate to fix misspellings in anything in "libs/3rdparty".
I'll attach a patch that fixes the rest of the issues I found & fixed. Zero functional improvement ;)
Cheers,
Dave.
Changed 2 years ago by dneary
Fix misspellings in QuteCom source code, docs, comments & UI files. I see designer has introduced some whitespace changes while it was at it. Lovely...
comment:4 Changed 2 years ago by dneary
You'll also need to make lupdate to update all the .ts files after applying the patch.
comment:5 in reply to: ↑ 3 Changed 2 years ago by cavedon
Replying to dneary:
For most of the other spelling errors, they're in code comments mostly - in a few places there are some documentation issues we can fix. Also, a lot of these are in eXoSIP, which is an upstream for us. Fixes should really get proposed there.
At least for the 2.2 branch, osip and exosip were branched from upstream...
If for qutecom 3.0 they are now in sync with upstream, that's really good news!
Also, I don't think it's appropriate to fix misspellings in anything in "libs/3rdparty".
I agree
I'll attach a patch that fixes the rest of the issues I found & fixed. Zero functional improvement ;)
eheh, thanks
comment:6 Changed 2 years ago by laurent
- Resolution set to fixed
- Status changed from reopened to closed
bug fix : 85

Thanks Ludovico
bug fix : 698